Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vox Rework #1071

Closed
wants to merge 5 commits into from
Closed

Vox Rework #1071

wants to merge 5 commits into from

Conversation

Yatiyaya
Copy link

@Yatiyaya Yatiyaya commented Mar 2, 2024

About the PR

Changing vox for the better, actually making oxygen bad for them, updating sprites to Beany Sprout Vox, etc.

Why / Balance

Birb

Technical details

Adding customized armor traits to the vox to fit the bio-engineered them

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Most of it, well no. Most of it works, just needs refining/fine tuning

Changelog
Le'Vox.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

RSI Diff Bot; head commit 70f2b73 merging into 1725dd1
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Customization/eyes.rsi

State Old New Status
vox_eyes_s Modified

Resources/Textures/Mobs/Customization/vox_hair.rsi

State Old New Status
vox_mohawk_s Modified
vox_shortquills_s Modified
vox_longquills_s Added
vox_stubble_s Added

Resources/Textures/Mobs/Species/Vox/parts.rsi

State Old New Status
groin_f Modified
groin_m Modified
head_f Modified
head_m Modified
l_arm Modified
l_foot Modified
l_hand Modified
l_leg Modified
r_arm Modified
r_foot Modified
r_hand Modified
r_leg Modified
torso_f Modified
torso_m Modified
vox_m Modified

Resources/Textures/Mobs/Customization/vox_hair.rsi/OLDVOX

State Old New Status
vox_mohawk_s Added
vox_shortquills_s Added

Resources/Textures/Mobs/Customization/vox_parts.rsi

State Old New Status
ArmMarkingsL Added
ArmMarkingsR Added
Beak Added
ClawsChest Added
ClawsLArm Added
ClawsLLeg Added
ClawsRArm Added
ClawsRLeg Added
Crest Added
Neck_markings Added
Scutes Added
ScutesLArm Added
ScutesLLeg Added
ScutesRArm Added
ScutesRLeg Added
Tail Added
reptoavian_gasmask Added
reptoavian_gloves Added
reptoavian_shoes Added

@Yatiyaya
Copy link
Author

Yatiyaya commented Mar 2, 2024

It's shit, I did random ass idea.

Draft for a reason

Copy link
Contributor

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realistically this should go to Wizard's Den.
I don't know if this repo uses codebase change markers but all of this needs to be marked if it does.

Comment on lines +3 to +4
"dotnet.defaultSolution": "SpaceStation14.sln",
"dotnet.preferCSharpExtension": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dotnet.defaultSolution": "SpaceStation14.sln",
"dotnet.preferCSharpExtension": true
"dotnet.defaultSolution": "SpaceStation14.sln"

@@ -1,13 +1,4 @@
marking-VoxHairLongQuills = Long Vox Quills
marking-VoxHairMohawk = Quillhawk?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

?

@@ -7,7 +7,8 @@
abstract: true
components:
- type: Damageable
damageContainer: Biological
damageContainer: VoxMade
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damageContainers are used to differentiate between humanoids, walls, and robots, this shouldn't be changed until someone makes a better way to get these differences

@@ -47,3 +47,14 @@
- Toxin
supportedTypes:
- Shock

- type: damageContainer
id: VoxMade # Radiation-Proofing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Radiation-Proofing

Set the radiation damage modifier to 0 instead of removing the container

@@ -250,6 +250,19 @@
Radiation: 0.2
Caustic: 0.0

- type: damageModifierSet
id: Primalis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id: Primalis
id: Vox

color: "#bc7d3e"
sprites:
- sprite: Mobs/Customization/vox_parts.rsi
state: ScutesLArm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
state: ScutesLArm
state: ScutesLArm

color: "#bc7d3e"
sprites:
- sprite: Mobs/Customization/vox_parts.rsi
state: ScutesLLeg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
state: ScutesLLeg
state: ScutesLLeg

color: "#bc7d3e"
sprites:
- sprite: Mobs/Customization/vox_parts.rsi
state: ScutesRArm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
state: ScutesRArm
state: ScutesRArm

Poison: -0.02
groups:
Burn: -0.07

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't touch RT

@dvir001
Copy link
Contributor

dvir001 commented Mar 2, 2024

Im so confused about this one, is this a DeltaV race? original?
If its an upstream race this should be done on upstream

@Yatiyaya Yatiyaya closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants